MAT-7471: Disable auto-encoding on FhirTerminologyServiceWebClient #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotanchik-SB
changed the title
… a custom UriBuilderFactory. Our config of the `FhirTerminologyServiceWebClient` enabled auto-encoding of String uri values by setting the `WebClient.Builder baseUrl()`. Effectively a shortcut to use the default `UriBuilderFactory`, which encodes uri Strings by default. When a URI object is passed to the WebClient request chain, the `UriBuilderFactory` is not used. Instead, the WebClient uses the supplied URI as is, which also means it doesn't use baseUrl configured on the WebClient builder as the underlying UriBuilderFactory is also not used. See: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/reactive/function/client/WebClient.Builder.html#baseUrl(java.lang.String) See: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/util/DefaultUriBuilderFactory.html#setEncodingMode(org.springframework.web.util.DefaultUriBuilderFactory.EncodingMode)
jkotanchik-SB
force-pushed
the
feature/mat-7471-manual-hmtl-encoding
branch
from
7ab8bdb to
9fee360
Compare
jkotanchik-SB
changed the title
adongare
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminology Service PR
Jira Ticket: MAT-7471
(Optional) Related Tickets:
Summary
Manually control when uri data is html encoded by disabling auto-encoding on
FhirTerminologyServiceWebClient.Our config of the
FhirTerminologyServiceWebClientauto-encodes String uri values by way of setting theWebClient.Builder baseUrl(). Effectively, doing so serves as a shortcut to use the defaultUriBuilderFactory, which is configured to encode uri Strings by default.When a URI object is passed to the WebClient request chain, the
UriBuilderFactoryis not used. Instead, the WebClient uses the supplied URI as is. Which also means it does not use thebaseUrlset on the WebClient since thebaseUrlis passed down to the defaultUriBuilderFactoryinstance that gets bypassed when making a request with a URI object.See: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/reactive/function/client/WebClient.Builder.html#baseUrl(java.lang.String)
See: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/util/DefaultUriBuilderFactory.html#setEncodingMode(org.springframework.web.util.DefaultUriBuilderFactory.EncodingMode)
All Submissions
DevSecOps
If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.
Reviewers
By Approving this PR you are attesting to the following: